Skip to content

PEP 639 compliance #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PEP 639 compliance #1166

wants to merge 2 commits into from
+2 −3

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jul 31, 2025 •
edited
Loading

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review July 31, 2025 08:46
@RonnyPfannschmidt
Copy link
Contributor

windows errors are unrelated and fixed in another pr

@RonnyPfannschmidt
Copy link
Contributor

this implicitly makes the project python 3.9 plus - so it will have to wait until after the 8.4 release as i want to ensure bugfixes for build issues with python3.8 and 3.9 deliver to down-streams/enterprise distro users

@RonnyPfannschmidt RonnyPfannschmidt added this to the v9.0 milestone Jul 31, 2025
@DimitriPapadopoulos
Copy link
Contributor Author

Additionally, part of the ecosystem (pip-licenses) doesn't support PEP 639 yet.

DimitriPapadopoulos
DimitriPapadopoulos commented Jul 31, 2025
View reviewed changes
@DimitriPapadopoulos
No need to explictly specify LICENSE file
01877f3 
Indeed setuptools will automatically pick up files with standard names,
including `LICEN[CS]E*`:
https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html
RonnyPfannschmidt
RonnyPfannschmidt approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for preparing this - the failing tests are from python versions to remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @RonnyPfannschmidt